-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sharing): migrate QuickShareSelect to NcActions #43213
fix(sharing): migrate QuickShareSelect to NcActions #43213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 works great!
Waiting for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Tested with NcVue 8.6.1 and works perfectly :)
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
4c4bb24
to
98d9fb1
Compare
Rebased onto master after upgrading |
/backport to stable28 |
/backport 66ba4c1 to stable28 |
…uick-share-select-to-nc-actions fix(sharing): migrate QuickShareSelect to NcActions
@nextcloud/vue@8.6.0
Summary
The current custom quick share select implementation has a number of a11y issues:
aria-expanded="false"
aria-selected
only ontrue
, which is not allowed here and should hasfalse
valueHaving all of that, it seems that moving to
NcActions
withmenu
+menuitemradio
semantics and some custom styles for the trigger is the best and easiest way to fix all a11y issues.Screenshots
Checklist