-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added last two places for aria-labels on setting icons #43369
Merged
Pytal
merged 1 commit into
master
from
fix/a11y/42855/add-last-two-aria-labels-for-icons
Feb 6, 2024
Merged
fix: added last two places for aria-labels on setting icons #43369
Pytal
merged 1 commit into
master
from
fix/a11y/42855/add-last-two-aria-labels-for-icons
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoral435
requested review from
JuliaKirschenheuter,
Pytal,
ShGKme and
szaimen
February 5, 2024 23:18
/backport 4f5880f to stable28 |
Pytal
reviewed
Feb 6, 2024
Pytal
approved these changes
Feb 6, 2024
ShGKme
approved these changes
Feb 6, 2024
JuliaKirschenheuter
approved these changes
Feb 6, 2024
emoral435
force-pushed
the
fix/a11y/42855/add-last-two-aria-labels-for-icons
branch
2 times, most recently
from
February 6, 2024 13:55
b1fb903
to
f654635
Compare
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435
force-pushed
the
fix/a11y/42855/add-last-two-aria-labels-for-icons
branch
from
February 6, 2024 14:42
f654635
to
05d5546
Compare
Cypress unrelated |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/43369/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4f5880f9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43369/stable28 Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After review, there was two places within the list mentioned in the original issue that still need to have their aria-label added. These places are places that still need to be translated to Vue, but for now, they will have their aria-label added here!
TODO
Checklist