Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added last two places for aria-labels on setting icons #43369

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Feb 5, 2024

Summary

After review, there was two places within the list mentioned in the original issue that still need to have their aria-label added. These places are places that still need to be translated to Vue, but for now, they will have their aria-label added here!

setttings/admin settings/admin/overview
image image

TODO

  • Add area label to these sections...
    • index.php/settings/admin
    • index.php/settings/admin/overview

Checklist

@emoral435 emoral435 added this to the Nextcloud 29 milestone Feb 5, 2024
@emoral435 emoral435 self-assigned this Feb 5, 2024
@emoral435
Copy link
Contributor Author

/backport 4f5880f to stable28

@emoral435 emoral435 force-pushed the fix/a11y/42855/add-last-two-aria-labels-for-icons branch 2 times, most recently from b1fb903 to f654635 Compare February 6, 2024 13:55
@emoral435 emoral435 enabled auto-merge February 6, 2024 13:55
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the fix/a11y/42855/add-last-two-aria-labels-for-icons branch from f654635 to 05d5546 Compare February 6, 2024 14:42
@Pytal Pytal disabled auto-merge February 6, 2024 18:45
@Pytal
Copy link
Member

Pytal commented Feb 6, 2024

Cypress unrelated

@Pytal Pytal merged commit 2db24f5 into master Feb 6, 2024
139 of 141 checks passed
@Pytal Pytal deleted the fix/a11y/42855/add-last-two-aria-labels-for-icons branch February 6, 2024 18:45
Copy link

backportbot bot commented Feb 6, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/43369/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4f5880f9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43369/stable28

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@Pytal
Copy link
Member

Pytal commented Feb 6, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants