Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix(files_sharing): Create passwords when enforced for mail shares #44569

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 29, 2024

Summary

Currently when trying to create a mail share there are a lot of errors in the browser console + if passwords are enforced mail shares will not work as the password is not set correctly.
This fixes some TypeErrors that prevent the password from being set.

Checklist

@susnux susnux added this to the Nextcloud 27.1.9 milestone Mar 29, 2024
@susnux susnux requested review from nfebe, skjnldsv, a team and szaimen and removed request for a team March 29, 2024 14:33
@susnux susnux changed the title fix(files_sharing): Create passwords when enforced for mail shares [stable27] fix(files_sharing): Create passwords when enforced for mail shares Mar 29, 2024
@susnux
Copy link
Contributor Author

susnux commented Mar 29, 2024

/backport! to stable28

@susnux
Copy link
Contributor Author

susnux commented Mar 29, 2024

/backport! to master

@susnux susnux force-pushed the fix/stable27-mail-share branch from 167e0ba to 88a809e Compare April 2, 2024 12:39
@susnux susnux requested review from artonge and emoral435 April 2, 2024 12:40
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux removed the request for review from artonge April 2, 2024 12:40
@susnux susnux force-pushed the fix/stable27-mail-share branch from 88a809e to 089c97a Compare April 2, 2024 13:58
@susnux
Copy link
Contributor Author

susnux commented Apr 2, 2024

/compile

@susnux susnux enabled auto-merge April 2, 2024 13:58
@susnux
Copy link
Contributor Author

susnux commented Apr 2, 2024

drone unrelated. cc @sorbaugh

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 2, 2024
susnux and others added 2 commits April 3, 2024 18:47
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux force-pushed the fix/stable27-mail-share branch from 3a6373c to bd2059a Compare April 3, 2024 16:47
@susnux susnux merged commit 96bf602 into stable27 Apr 3, 2024
38 checks passed
@susnux susnux deleted the fix/stable27-mail-share branch April 3, 2024 17:46
@Altahrim Altahrim mentioned this pull request Apr 17, 2024
4 tasks
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing feedback-requested regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants