fix(encryption): Clicking default module in UI sets bogus value

[joshtrichards]

• Resolves: [Bug]: Default encryption module not loaded (v2.16.0) #44532
• Likely fixes [Bug]: Unable to enable server-side encryption #43123 too

Summary

update() was hard coded to return a yes/no string value just to handle enableEncryption()'s value. Since update() is also used for setting the default encryption module (which is not a simple yes/no value), whenever the default encryption module radio button was clicked the server value was being set to yes too (which is bogus).

server/apps/settings/src/components/Encryption.vue

Lines 132 to 156 in 497a863

	async update(key, value) {
	await confirmPassword()
	const url = generateOcsUrl('/apps/provisioning_api/api/v1/config/apps/{appId}/{key}', {
	appId: 'core',
	key,
	})
	const stringValue = value ? 'yes' : 'no'
	try {
	const { data } = await axios.post(url, {
	value: stringValue,
	})
	this.handleResponse({
	status: data.ocs?.meta?.status,
	})
	} catch (e) {
	this.handleResponse({
	errorMessage: t('settings', 'Unable to update server side encryption config'),
	error: e,
	})
	}
	},
	async checkDefaultModule() {
	await this.update('default_encryption_module', this.defaultCheckedModule)

server/apps/settings/src/components/Encryption.vue

Lines 60 to 68 in 497a863

	<NcCheckboxRadioSwitch v-for="(module, id) in encryptionModules"
	:key="id"
	:checked.sync="defaultCheckedModule"
	:value="id"
	type="radio"
	name="default_encryption_module"
	@update:checked="checkDefaultModule">
	{{ module.displayName }}
	</NcCheckboxRadioSwitch>

How to test:

• Enable Encryption app under Apps
• Toggle on Server-side encryption under Admin Settings->Security
• Click Enable encryption
• Click anywhere on the Default encryption module radio button area
• Check the server-side value of default_encryption_module (e.g. occ config:list core)

Correct value: OC_DEFAULT_MODULE (which it'll be if you're careful not to click anywhere initially)
Bogus value: yes (which it'll change to if you click anywhere without this PR)

If your default_encryption_module is set to yes try this command to manually remedy:

occ encryption:set-default-module OC_DEFAULT_MODULE

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[joshtrichards]

/compile amend /

[joshtrichards]

/backport to stable29

[joshtrichards]

/backport to stable28

[joshtrichards]

/backport to stable27

[artonge]

👍

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!