Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): do not rely on unique fileid #45251

Merged
merged 3 commits into from
Jun 12, 2024
Merged

fix(files): do not rely on unique fileid #45251

merged 3 commits into from
Jun 12, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 10, 2024 •
edited
Loading

Fix the rendering of duplicates fileids in the Files app

How to

  1. Create a local external storage
  2. Create a second one wih the exact same path
  3. Open the Files app
  4. See an error in the log and scrolling starts to break

Solution

  • We do not store files by their ID anymore
  • Once we receive a node event, we will use the node payload as a source of truth ONLY if we have one entry in the store. If we don't we fetch the node data in the dav backend to refresh the content. This is an edge case, so the perf loss is accepted here

@skjnldsv skjnldsv force-pushed the fix/files-source-no-fileid branch from 963ee41 to 677783a Compare May 10, 2024 12:14
@skjnldsv
fix(files): do not rely on unique fileid
1d7893d 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/files-source-no-fileid branch from 677783a to 1d7893d Compare June 12, 2024 15:16
@skjnldsv skjnldsv marked this pull request as ready for review June 12, 2024 15:51
@skjnldsv skjnldsv force-pushed the fix/files-source-no-fileid branch from eddf1f7 to 251503b Compare June 12, 2024 15:55
@skjnldsv skjnldsv requested review from susnux, artonge, a team, nfebe and Pytal and removed request for a team June 12, 2024 15:55
@skjnldsv skjnldsv self-assigned this Jun 12, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jun 12, 2024
@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

@skjnldsv
fix(files): fetch nodes if we have multiple of the same fileid in the…
343b690 
… store

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/files-source-no-fileid branch from 251503b to 343b690 Compare June 12, 2024 15:57
@AndyScherzinger
Copy link
Member

/compile /

@nextcloud-command
chore(assets): Recompile assets
51791e5 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
susnux approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘 🧹

@AndyScherzinger AndyScherzinger merged commit 7093472 into master Jun 12, 2024
109 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/files-source-no-fileid branch June 12, 2024 20:54
This was referenced Jun 12, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Jun 13, 2024
Closed
8 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge Awaiting requested review from artonge

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: files technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @AndyScherzinger @susnux @nextcloud-command