Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ShareApiController): Correct note about expiry date timezone #45608

Merged
merged 1 commit into from
Jul 1, 2024
Merged

docs(ShareApiController): Correct note about expiry date timezone #45608

merged 1 commit into from
Jul 1, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented May 31, 2024

Fix notes for parameter annotation

@nfebe nfebe added this to the Nextcloud 30 milestone May 31, 2024
@nfebe nfebe requested review from Altahrim, come-nc and Antreesy May 31, 2024 13:34
@nfebe nfebe requested a review from provokateurin as a code owner May 31, 2024 13:34
@nfebe
Copy link
Contributor Author

nfebe commented May 31, 2024

/backport to stable29

@nfebe
Copy link
Contributor Author

nfebe commented May 31, 2024

/backport to stable27

@nfebe
Copy link
Contributor Author

nfebe commented May 31, 2024

Fixed on open backport on 28, so backport not need for stable28

provokateurin
provokateurin approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add the date format (probably ISO8601?).

@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nfebe
docs(ShareApiController): Correct note about expiry date timezone
6136112 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the fix-openapi-notes-share-api branch from 5f5ef5e to 6136112 Compare July 1, 2024 12:53
@nfebe nfebe enabled auto-merge July 1, 2024 12:53
@nfebe nfebe merged commit 5270ffc into master Jul 1, 2024
166 checks passed
@nfebe nfebe deleted the fix-openapi-notes-share-api branch July 1, 2024 17:22
This was referenced Jul 1, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@provokateurin provokateurin provokateurin approved these changes

@Altahrim Altahrim Altahrim approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees
No one assigned
Labels
feature: sharing feedback-requested
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@nfebe @Altahrim @provokateurin @come-nc