Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(files): Properly handle denied ownership transfers #45906

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 17, 2024

Backport of PR #45884

When the receiver denies the transfer the notification handler was missing,
so no notification was created for the transfer owner.

But also the internal notification was created two times:
1. When rejecting the transfer
2. By the reject function when dismissing the notification

This is fixed by only relying on the dismiss function.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@backportbot backportbot bot requested review from come-nc, SystemKeeper and susnux June 17, 2024 07:44
@backportbot backportbot bot added this to the Nextcloud 29.0.3 milestone Jun 17, 2024
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 17, 2024
@blizzz blizzz mentioned this pull request Jun 17, 2024
8 tasks
@susnux susnux merged commit 6f34a47 into stable29 Jun 25, 2024
166 of 168 checks passed
@susnux susnux deleted the backport/45884/stable29 branch June 25, 2024 16:03
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants