-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable29] fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root #45956
Conversation
d5cd9c2
to
caae551
Compare
|
Pushed 76efdb0 to fix the failing test. The router uses include_once to load route definitions from the apps. First include_once for apps/files/appinfo/routes.php returns the expected array. Second include_once returns true, because the file was already included. To workaround the tests must run in a separate process. I have no idea why the test is not failing on master. |
That does not seem to work
The test is not failing on master because the app manager instance is mocked, the app path is null and the routing file not even included: #46416 |
76efdb0
to
caae551
Compare
fa5a153
to
19dff6d
Compare
…dle redirected root Signed-off-by: Steve Mokris <steve@kosada.com>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
de1f1a8
to
a554ba5
Compare
Backport of PR #45228