fix(caldav): encode calendar URIs with umlauts for activities #45999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
added
bug
3. to review
st3iny
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
AndyScherzinger
approved these changes
Jun 20, 2024
ChristophWurst
approved these changes
Jun 20, 2024
|
/backport to stable29 |
st3iny
added
4. to release
|
/backport to stable28 |
This was referenced Jun 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #45775 to also handle umlauts in calendar URIs.
Umlauts have to be encoded with
urlencode()but the escaped hex sequences have to be lower case to match what SabreDAV does. We need to leave uppercase characters untouched in calendar URIs though.Checklist