Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SharingEntryLink): Show enforced password input label #46143

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jun 26, 2024

Summary

While upgrading icons in b3ec461 (#43774) enforced password label icon was not correctly wrapped.

Before After
Copie d'écran_20240618_100050 Screenshot from 2024-06-26 16-18-01

Resolves : #45941

@nfebe nfebe added 3. to review Waiting for reviews feature: sharing labels Jun 26, 2024
@nfebe nfebe added this to the Nextcloud 30 milestone Jun 26, 2024
@nfebe nfebe requested review from susnux, artonge, skjnldsv and Pytal June 26, 2024 15:19
@nfebe nfebe self-assigned this Jun 26, 2024
@nfebe
Copy link
Contributor Author

nfebe commented Jun 26, 2024

/backport to stable29

While upgrading icons in b3ec461 enforced password label
icon was not correctly wrapped.

Resolves : #45941

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@susnux susnux force-pushed the fix/45941/share-pass-label branch from f90e54a to 0c8fe40 Compare June 27, 2024 06:11
@susnux
Copy link
Contributor

susnux commented Jun 27, 2024

/compile

@susnux susnux enabled auto-merge June 27, 2024 06:11
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 07180e4 into master Jun 27, 2024
110 checks passed
@susnux susnux deleted the fix/45941/share-pass-label branch June 27, 2024 06:36
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

[Bug]: Label is missing for enforced password for link share
4 participants