Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(IntegrityCheck): Ensure the check is run if no results are available #46297

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 4, 2024

Backport of #46174

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews feature: settings php Pull requests that update Php code labels Jul 4, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.8 milestone Jul 4, 2024
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/46174/stable28 branch from 2c2a62a to 90d3160 Compare July 5, 2024 10:42
@susnux susnux marked this pull request as ready for review July 5, 2024 10:46
@solracsf solracsf enabled auto-merge July 6, 2024 14:38
@solracsf solracsf merged commit 936de57 into stable28 Jul 9, 2024
57 checks passed
@solracsf solracsf deleted the backport/46174/stable28 branch July 9, 2024 16:22
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: settings php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants