Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(carddav): limit vcard size #46313

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[stable28] fix(carddav): limit vcard size #46313

merged 1 commit into from
Jul 10, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 4, 2024

Backport of PR #46193

@backportbot backportbot bot requested a review from hamza221 July 4, 2024 22:17
@backportbot backportbot bot requested a review from tcitworld as a code owner July 4, 2024 22:17
@backportbot backportbot bot added the 3. to review Waiting for reviews label Jul 4, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.8 milestone Jul 4, 2024
@SebastianKrupinski SebastianKrupinski force-pushed the backport/46193/stable28 branch 2 times, most recently from 4d3e97f to 2701f10 Compare July 4, 2024 23:41
@SebastianKrupinski SebastianKrupinski force-pushed the backport/46193/stable28 branch 2 times, most recently from 2a0a7f4 to e2bd10e Compare July 5, 2024 16:50
@ChristophWurst
Copy link
Member

OCA\DAV\Tests\unit\CardDAV\Validation\CardDavValidatePluginTest::testPutSizeLessThenLimit
PHPUnit\Framework\MockObject\MethodCannotBeConfiguredException: Trying to configure method "getValue" which cannot be configured because it does not exist, has not been specified, is final, or is static

unit tests 😍

@Altahrim Altahrim mentioned this pull request Jul 10, 2024
Merged
@AndyScherzinger AndyScherzinger force-pushed the backport/46193/stable28 branch from 3e7292b to 8ecfbc7 Compare July 10, 2024 13:14
@SebastianKrupinski
fix(carddav): limit vcard size
cce9558 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the backport/46193/stable28 branch from 8ecfbc7 to cce9558 Compare July 10, 2024 14:43
@st3iny st3iny merged commit 63acc67 into stable28 Jul 10, 2024
54 checks passed
@st3iny st3iny deleted the backport/46193/stable28 branch July 10, 2024 18:38
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solracsf solracsf solracsf left review comments

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@miaulalala miaulalala Awaiting requested review from miaulalala

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees

@SebastianKrupinski SebastianKrupinski

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 28.0.8
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @st3iny @miaulalala @solracsf @SebastianKrupinski