Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(Session): avoid race conditions on clustered setups #46437

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 11, 2024

Backport of PR #46398

blizzz added 2 commits July 11, 2024 07:29
- re-stablishes old behaviour with cache to return null instead of throwing
  an InvalidTokenException when the token is cached as non-existing
- token invalidation and re-generation are bundled in a DB transaction now

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
prefer to keep this check as PublicEmitter should be dropped sooner or
later

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz mentioned this pull request Jul 11, 2024
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 11, 2024
@AndyScherzinger AndyScherzinger merged commit f9e1006 into stable29 Jul 11, 2024
172 of 177 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/46398/stable29 branch July 11, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: authentication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants