Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editLocallyAction): Handle possible no local client scenario #46452

Merged
merged 3 commits into from
Jul 31, 2024
Merged

feat(editLocallyAction): Handle possible no local client scenario #46452

merged 3 commits into from
Jul 31, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jul 11, 2024 •
edited
Loading

Summary

Resolves: #46438

Screencast

Screencast.from.2024-07-12.01-43-50.webm

TODO

  • Screenshots ?

@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch 8 times, most recently from a113d41 to c45e176 Compare July 12, 2024 00:41
@nfebe nfebe marked this pull request as ready for review July 12, 2024 00:41
@nfebe nfebe requested a review from skjnldsv as a code owner July 12, 2024 00:41
@nfebe nfebe requested review from a team, Pytal and sorbaugh and removed request for a team July 12, 2024 00:45
@nfebe nfebe added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 12, 2024
@nfebe nfebe enabled auto-merge July 12, 2024 00:46
@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch 3 times, most recently from ce7055b to 0ef4ad3 Compare July 12, 2024 14:41
@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch from 0ef4ad3 to 43aade3 Compare July 15, 2024 11:22
@nfebe nfebe requested review from Pytal and susnux July 15, 2024 11:23
Pytal
Pytal reviewed Jul 15, 2024
View reviewed changes
apps/files/src/actions/editLocallyAction.ts Outdated
.then(() => {
// Ensure the callback is called even if the dialog is dismissed in other ways
if (!callbackCalled) {
localEditCallback(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO closing the dialog should have the same effect as cancelling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, but I was like maybe it's better to just proceed with action the user was attempting to do in the first place if they are clicking outside the modal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any strong feeling about this, any is fine for me.

@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch from 43aade3 to 9ad0a2b Compare July 15, 2024 23:28
@nfebe nfebe requested a review from Pytal July 15, 2024 23:29
@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch from 9ad0a2b to 038b40b Compare July 16, 2024 01:14
@nfebe
Copy link
Contributor Author

nfebe commented Jul 16, 2024

/compile /

@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch 2 times, most recently from 0b526e1 to 0274821 Compare July 17, 2024 08:43
@nfebe
Copy link
Contributor Author

nfebe commented Jul 17, 2024

/compile /

@skjnldsv
Copy link
Member

@fenn-cs can you fix the test please?

@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch from 4578636 to d22fe6e Compare July 31, 2024 09:24
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
267ae6f 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch 2 times, most recently from 50110c6 to 08df57e Compare July 31, 2024 09:26
@nfebe
fix: Adjust tests for editLocallyAction
efcf98d 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the feat/46438/provide-feedback-edit-locally branch from 08df57e to efcf98d Compare July 31, 2024 09:28
@nfebe
Copy link
Contributor Author

nfebe commented Jul 31, 2024

/compile /

@nfebe
Copy link
Contributor Author

nfebe commented Jul 31, 2024

/backport to stable29

@nfebe
Copy link
Contributor Author

nfebe commented Jul 31, 2024

/backport to stable28

@nextcloud-command
chore(assets): Recompile assets
3d14959 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit 0e2ef42 into master Jul 31, 2024
111 checks passed
@nfebe nfebe deleted the feat/46438/provide-feedback-edit-locally branch July 31, 2024 10:09
This was referenced Jul 31, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

@susnux susnux Awaiting requested review from susnux

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: files feedback-requested
Projects
📁 Files team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workaround when selecting "edit locally" as an option
5 participants
@nfebe @skjnldsv @susnux @Pytal @nextcloud-command