Sort events by descending date #46549
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| usort($searchResults, function ($a, $b) { | ||
| $componentA = $this->getPrimaryComponent($a['calendardata'], self::$componentType); | ||
| $componentB = $this->getPrimaryComponent($b['calendardata'], self::$componentType); | ||
| $dateA = $componentA->DTSTART->getDateTime(); |
Check notice
Code scanning / Psalm
PossiblyNullReference
| usort($searchResults, function ($a, $b) { | ||
| $componentA = $this->getPrimaryComponent($a['calendardata'], self::$componentType); | ||
| $componentB = $this->getPrimaryComponent($b['calendardata'], self::$componentType); | ||
| $dateA = $componentA->DTSTART->getDateTime(); |
Check notice
Code scanning / Psalm
UndefinedMethod
| $componentA = $this->getPrimaryComponent($a['calendardata'], self::$componentType); | ||
| $componentB = $this->getPrimaryComponent($b['calendardata'], self::$componentType); | ||
| $dateA = $componentA->DTSTART->getDateTime(); | ||
| $dateB = $componentB->DTSTART->getDateTime(); |
Check notice
Code scanning / Psalm
PossiblyNullReference
| $componentA = $this->getPrimaryComponent($a['calendardata'], self::$componentType); | ||
| $componentB = $this->getPrimaryComponent($b['calendardata'], self::$componentType); | ||
| $dateA = $componentA->DTSTART->getDateTime(); | ||
| $dateB = $componentB->DTSTART->getDateTime(); |
Check notice
Code scanning / Psalm
UndefinedMethod
| } | ||
|
|
||
| protected function generateSubline(Component $eventComponent): string { | ||
| protected function generateSubline(Component $eventComponent): string |
Check notice
Code scanning / Psalm
InvalidReturnType
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Killiane Letellier <killiane.letellier@mailo.com>
joshtrichards
force-pushed
the
patch-1
branch
from
94e36b4 to
b0f9f70
Compare
|
Thank you for starting this! When testing this PR, I noticed that sorting of events works nicely. But events are still loaded / paginated starting with the oldest event first.
|
6 participants
Summary
Implemented sorting of events by descending start date in the EventsSearchProvider class.
This ensures that the most recent events appear first in the search results.
Checklist