Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FileInfo from View should have the correct name of a mountpoint #46694

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 22, 2024

Summary

If a mountpoint is returned from a View the name must match the view scoped name and not the global name.
For example group folders have a name like 1 or 2 (the ID), but the name of the FileInfo returned fro mthe View should be the mount point name, like First groupfolder or similar.

Checklist

If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 30 milestone Jul 22, 2024
@susnux susnux requested review from a team, ArtificialOwl, icewind1991, yemkareems and sorbaugh and removed request for a team July 22, 2024 23:13
@susnux
Copy link
Contributor Author

susnux commented Jul 24, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Jul 24, 2024

/backport to stable28

@sorbaugh sorbaugh merged commit 52fe7b1 into master Jul 24, 2024
167 checks passed
@sorbaugh sorbaugh deleted the fix/file-info-name branch July 24, 2024 13:22
Copy link

backportbot bot commented Jul 24, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/46694/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 12796c3a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46694/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/46694/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants