Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(files): Correctly validate new node name #46774

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 26, 2024

Backport of #46767

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from nfebe, skjnldsv and susnux July 26, 2024 09:12
@backportbot backportbot bot added this to the Nextcloud 29.0.5 milestone Jul 26, 2024
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 27, 2024
susnux added 2 commits August 2, 2024 22:08
* Resolves #45409

This includes two fixes:

1. The name in the "new node" dialog is correctly selected (e.g. `file.txt` only `file` is selected by default), to allow quick naming

2. `@nextcloud/files` functions for filename validation are used, this allows to use new Nextcloud 30 capabilities (e.g. reserved names)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/46767/stable29 branch from 4b50cee to f1d9ab1 Compare August 2, 2024 20:10
@susnux susnux marked this pull request as ready for review August 2, 2024 20:10
@susnux susnux requested a review from Pytal August 2, 2024 20:10
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 2, 2024
@skjnldsv skjnldsv enabled auto-merge August 3, 2024 06:05
@skjnldsv skjnldsv merged commit b41a8ac into stable29 Aug 3, 2024
112 of 114 checks passed
@skjnldsv skjnldsv deleted the backport/46767/stable29 branch August 3, 2024 06:14
@susnux
Copy link
Contributor

susnux commented Aug 5, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants