Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): Make sure footer with legal links is shown correctly #46784

Merged
merged 4 commits into from
Jul 27, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 26, 2024

Summary

Fix public pages footer height. If there are legal links or a signup link or both we need different heights of the footer.
Otherwise the footer content will be clipped and overlay the app.

Adjusted colors in the screen shots to make clear what is which element:

before after
Screenshot 2024-07-26 at 15-01-20 Dateien - Nextcloud Screenshot 2024-07-26 at 15-00-15 Dateien - Nextcloud
Screenshot 2024-07-26 at 15-01-01 Dateien - Nextcloud Screenshot 2024-07-26 at 14-59-50 Dateien - Nextcloud

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jul 26, 2024
@susnux susnux added this to the Nextcloud 30 milestone Jul 26, 2024
@susnux susnux requested review from juliusknorr, mejo- and szaimen July 26, 2024 13:15
@susnux
Copy link
Contributor Author

susnux commented Jul 26, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Jul 26, 2024

/backport to stable28

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the screenshots but didnt test and didnt review the code

@susnux susnux requested a review from skjnldsv July 26, 2024 13:23
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv
Copy link
Member

/compile /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 27, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
4 participants