Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(files): trim names on new node creation #47150

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 9, 2024

@backportbot backportbot bot requested review from sorbaugh, szaimen and skjnldsv August 9, 2024 12:40
@backportbot backportbot bot added this to the Nextcloud 28.0.9 milestone Aug 9, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 9, 2024

Seems like the old NewNodeDialog.vue already trims, this was lost in stable29 via #46767 + #46774

const newName = this.localDefaultName.trim?.() || ''

const trimmedName = name.trim()

@skjnldsv
Copy link
Member

skjnldsv commented Aug 9, 2024

/compile amend /

@skjnldsv skjnldsv marked this pull request as ready for review August 9, 2024 13:06
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the backport/47147/stable28 branch from 74e43c0 to a768f45 Compare August 9, 2024 13:11
@skjnldsv skjnldsv enabled auto-merge August 9, 2024 13:34
@skjnldsv skjnldsv merged commit bb2b64d into stable28 Aug 9, 2024
45 checks passed
@skjnldsv skjnldsv deleted the backport/47147/stable28 branch August 9, 2024 13:38
@solracsf solracsf mentioned this pull request Aug 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants