Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): auto-lock closed issues and PRs older than X days #49033

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Oct 31, 2024

Summary

Lock Threads is a GitHub Action that locks closed threads (issues, PRs) after a certain (configurable) period of inactivity.

The proposed workflow will search once a week (on sunday) for closed issues and pull requests that have not had any activity in the past 120 days, and lock them to Nextcloud collaborators only (whose can unlock/reopen/comment on them if needed).

This should prevent regular users to comment on old (out-of-date) threads and invite them to open a new issue instead, with up-to-date material.

More info at https://github.com/dessant/lock-threads

Checklist

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf requested review from szaimen, joshtrichards and a team October 31, 2024 13:43
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf changed the title feat(workflows): lock threads older than 120 days feat(workflows): lock closed threads older than 120 days Oct 31, 2024
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for now for internal discussion

@solracsf solracsf changed the title feat(workflows): lock closed threads older than 120 days feat(workflows): auto-lock closed issues and PRs older than 120 days Oct 31, 2024
@kesselb
Copy link
Contributor

kesselb commented Nov 1, 2024

👍

I fear this will create a huge number of notifications, but I like the idea. It happens that people respond to issues and prs that were closed years ago and never receive a response (e.g. because the involved people are not there anymore).

@joshtrichards
Copy link
Member

I fear this will create a huge number of notifications, but I like the idea.

@kesselb You mean initially? We could incrementally tweak the options to chunk it. I guess this is one of those "rip the band-aid off things". Or, for the initial batch (existing closed Issues), we could configure to lock w/o comment. As long as the reason is set to resolved, even without adding a comment, it'll look like this (minus the locker name since that doesn't get shown publicly):

image

Once that's done we can add the explanation comment+lock back in for newly closed Issues going forward.

@solracsf I've thought about doing this. Thanks for taking action and pushing us all to think this through to see if we want to do it.

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Nov 2, 2024

I would even say an issue (bug report!) which was closed and not marked as stale (thus resolved) be be locked right after closing.
If there is a regression, then a new issue should be created.

@solracsf solracsf changed the title feat(workflows): auto-lock closed issues and PRs older than 120 days feat(workflows): auto-lock closed issues and PRs older than X days Nov 3, 2024
@solracsf
Copy link
Member Author

Any news for a Go/no-Go here ?

@provokateurin
Copy link
Member

I think we wanted to have this, but I just brought it up in our team chat again to see how we want to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants