Bring back the description for app passwords #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
MorrisJobke,
jancborchardt and
ChristophWurst
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @ChristophWurst and @LukasReschke to be potential reviewers. |
This was referenced Jun 6, 2017
ChristophWurst
approved these changes
Jun 6, 2017
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Codecov Report
@@ Coverage Diff @@
## master #5265 +/- ##
=========================================
Coverage 54.17% 54.17%
Complexity 22302 22302
=========================================
Files 1380 1380
Lines 85383 85383
Branches 1321 1321
=========================================
Hits 46259 46259
Misses 39124 39124
|
|
Please backport. |
|
It's already in the PR of the initial backport which caused this regression: |
|
Nice, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5166