fix(files_trashbin): check if there is enough space before restoring #52752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftybournes
requested review from
nfebe and
susnux
and removed request for
a team
susnux
reviewed
May 12, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Not sure as the "free space" is cached and could be larger or smaller.
So worst case this is cancelled even if there is enough space, just because its cached with smaller free space.
Maybe instead do that on the trashbin DAV plugin and check if there is enough free space, otherwise fail and report the missing space (http 507).
So we can catch and handle in frontend, but backend has a chance to properly check this.
Contributor
Author
|
Thanks for pointing that out. I'll look into doing it that way instead. |
leftybournes
force-pushed
the
leftybournes/fix/files_trashbin_dont_restore_full
branch
from
3cc6de7 to
51ec256
Compare
leftybournes
requested review from
ArtificialOwl and
artonge
and removed request for
a team
leftybournes
force-pushed
the
leftybournes/fix/files_trashbin_dont_restore_full
branch
3 times, most recently
from
bad3873 to
417576a
Compare
leftybournes
force-pushed
the
leftybournes/fix/files_trashbin_dont_restore_full
branch
from
417576a to
30b49cd
Compare
leftybournes
force-pushed
the
leftybournes/fix/files_trashbin_dont_restore_full
branch
from
30b49cd to
bba3e3c
Compare
provokateurin
requested changes
May 20, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, just some minor ideas for improvement
leftybournes
force-pushed
the
leftybournes/fix/files_trashbin_dont_restore_full
branch
from
94da0a3 to
3eb1214
Compare
provokateurin
approved these changes
May 20, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Did not test, but looks nice!
leftybournes
force-pushed
the
leftybournes/fix/files_trashbin_dont_restore_full
branch
from
3eb1214 to
9820280
Compare
Signed-off-by: Kent Delante <kent.delante@proton.me>
leftybournes
force-pushed
the
leftybournes/fix/files_trashbin_dont_restore_full
branch
from
9820280 to
705aee5
Compare
yemkareems
approved these changes
May 27, 2025
provokateurin
deleted the
leftybournes/fix/files_trashbin_dont_restore_full
branch
Contributor
Author
|
/backport to stable31 |
2 tasks
Contributor
Author
|
/backport to stable30 |
2 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check if a user has enough space to restore a file before doing it.
Checklist