[stable30] feat(files_trashbin): Refactor expire background job to support parallel run #53025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
enhancement
3. to review
artonge
force-pushed
the
backport/52825/stable30
branch
2 times, most recently
from
75b1cd1 to
6b71353
Compare
artonge
approved these changes
May 21, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
backportbot
bot
force-pushed
the
backport/52825/stable30
branch
from
6b71353 to
0d622c9
Compare
artonge
force-pushed
the
backport/52825/stable30
branch
2 times, most recently
from
75ebc60 to
1f2fc25
Compare
AndyScherzinger
approved these changes
Jun 4, 2025
skjnldsv
added
the
♻️ refactor
Member
|
@artonge merge? |
artonge
force-pushed
the
backport/52825/stable30
branch
3 times, most recently
from
56e4db0 to
8e8c280
Compare
backportbot
bot
force-pushed
the
backport/52825/stable30
branch
from
8e8c280 to
907cc5c
Compare
artonge
force-pushed
the
backport/52825/stable30
branch
from
907cc5c to
dddf105
Compare
|
|
||
| } | ||
|
|
||
| private function resetOffset() { |
Check notice
Code scanning / Psalm
MissingReturnType Note
| }); | ||
| } | ||
|
|
||
| private function runMutexOperation($operation): mixed { |
Check notice
Code scanning / Psalm
MissingParamType Note
artonge
force-pushed
the
backport/52825/stable30
branch
from
dddf105 to
10aa280
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
…lel run - Follow-up of #51600 The original PR introduced the possibility to continue an `ExpireTrash` job by saving the offset. This was to prevent having to start over the whole user list when the job crashed or was killed. But on big instances, one process is not enough to go through all the users in a timely manner. Supporting parallel run allows covering more ground faster. This PR introduced this possibility. We are now storing the offset right away to allow another parallel job to pick up the task at that point. We are arbitrarily cutting the user list in chunk of 10 to not drastically overflow the 30 minutes time limit. Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
backport/52825/stable30
branch
from
10aa280 to
1f464b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #52825
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.