don't send invitation emails for past events #5304

georgehrke · 2017-06-08T09:56:26Z

codecov · 2017-06-09T10:13:31Z

Codecov Report

Merging #5304 into master will decrease coverage by 0.62%.
The diff coverage is 71.79%.

@@             Coverage Diff              @@
##             master    #5304      +/-   ##
============================================
- Coverage     54.49%   53.86%   -0.63%     
- Complexity    21220    22777    +1557     
============================================
  Files          1313     1405      +92     
  Lines         82440    86748    +4308     
  Branches       1329     1328       -1     
============================================
+ Hits          44922    46727    +1805     
- Misses        37518    40021    +2503

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/appinfo/v1/caldav.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
config/config.sample.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
apps/dav/lib/Server.php	`47.82% <100%> (+0.38%)`	`13 <0> (+1)`	⬆️
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php	`75.36% <80.64%> (+4.3%)`	`22 <9> (+21)`	⬆️
lib/private/Files/ObjectStore/S3.php	`0% <0%> (-73.69%)`	`5% <0%> (ø)`
apps/files/appinfo/app.php	`43.47% <0%> (-56.53%)`	`0% <0%> (ø)`
...ib/private/Files/ObjectStore/S3ConnectionTrait.php	`0% <0%> (-54.17%)`	`22% <0%> (ø)`
apps/files_sharing/appinfo/app.php	`43.9% <0%> (-46.1%)`	`0% <0%> (ø)`
apps/user_ldap/templates/part.settingcontrols.php	`0% <0%> (-42.86%)`	`0% <0%> (ø)`
apps/files_trashbin/appinfo/app.php	`60% <0%> (-40%)`	`0% <0%> (ø)`
... and 447 more

LukasReschke · 2017-06-12T20:13:32Z

apps/dav/appinfo/v1/caldav.php

@@ -52,6 +52,7 @@
 $calDavBackend = new CalDavBackend($db, $principalBackend, $userManager, $random, $dispatcher, true);

 $debugging = \OC::$server->getConfig()->getSystemValue('debug', false);
+$sendInvitations = \OC::$server->getConfig()->getSystemValue('caldav_send_invitations', true);


I'm usually not really a fan of configuration values. Is there a reason we do really need to have that one? 🙈

Also stuff in the app config is usually easier to deploy on clusters :)

see #2800, #3830
some people run into issues with our server side scheduling and just want to keep sending their invitations via thunderbird.
or they just don't like that invitations are sent out by the server's email address, not their own one.

Not sure we will ever change that value on clusters.

Besides this configuration value, it would be more intuitive to have a checkbox when importing a calendar. The user itself, who has no access to the config.php should be able to decide whether to send invitaions for future events or not while importing a calendar.

it would be more intuitive to have a checkbox when importing a calendar

Or maybe never send invitations on import?
Anyway, that's out of scope for this pr.
Let's continue the discussion here: nextcloud/calendar#576

I would also not make it a server wide setting. Just remove the added stuff (compared to the backport) and then we can get this in.

Ok, I will remove that commit for now.
I would anyway still like to add this feature in the future.

Should I just implement it via the appconfig table?

kosli · 2017-06-27T22:48:56Z

any update on merging this pull request?

georgehrke · 2017-06-28T20:26:55Z

@kosli There is still something missing, see the first post. Won't have time to look into this before the weekend.

kosli · 2017-06-29T08:23:09Z

@georgehrke ups, I didn't see the ToDo on top. Thanks!

georgehrke · 2017-07-17T10:40:53Z

rebased

georgehrke · 2017-07-17T10:41:56Z

One thing I wasn't sure about:

Should it not send out invitations for any events in the past or only for events that are older than 2 weeks / month ?

jospoortvliet · 2017-07-18T18:23:13Z

I wouldn't sent out any invitations for past events, after all those either have been sent already or the user decided not to sent them...

Or are you afraid some events would end up being missed?

georgehrke · 2017-07-23T07:39:20Z

Backport to review once this is merged: #5841

ggeorgg · 2017-08-22T10:54:18Z

Import of a calendar in a fresh nextcloud 12.0.1 with these changes applied is working. The option to turn off resending invitation mails via the config setting is also working.

jospoortvliet · 2017-08-24T07:53:41Z

@LukasReschke happy with the changes/feedback from Georg? It'd be nice to get this in so 12.0.3 will not resent all these invitations 😢

MorrisJobke · 2017-08-30T19:04:35Z

apps/dav/appinfo/v1/caldav.php

@@ -52,6 +52,7 @@
 $calDavBackend = new CalDavBackend($db, $principalBackend, $userManager, $random, $dispatcher, true);

 $debugging = \OC::$server->getConfig()->getSystemValue('debug', false);
+$sendInvitations = \OC::$server->getConfig()->getSystemValue('caldav_send_invitations', true);


I would also not make it a server wide setting. Just remove the added stuff (compared to the backport) and then we can get this in.

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Fixed

jospoortvliet · 2017-09-07T08:19:30Z

AWESOME!

georgehrke added the 2. developing Work in progress label Jun 8, 2017

georgehrke added this to the Nextcloud 13 milestone Jun 8, 2017

georgehrke force-pushed the bugfix/2855/dont_send_invitations_for_past_events branch from 6d74321 to 677267b Compare June 9, 2017 10:13

georgehrke mentioned this pull request Jun 9, 2017

Server side scheduling #2800

Closed

LukasReschke previously requested changes Jun 12, 2017

View reviewed changes

georgehrke mentioned this pull request Jun 12, 2017

Calendar invites: Sender is server instance, not user email address #2345

Closed

georgehrke force-pushed the bugfix/2855/dont_send_invitations_for_past_events branch from 677267b to 7e24c8c Compare July 17, 2017 10:40

georgehrke requested review from nickvergessen and schiessle July 17, 2017 10:41

georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 18, 2017

georgehrke mentioned this pull request Jul 18, 2017

Invitation send to attendees upon calendar import (also for past events) #2855

Closed

georgehrke added the backport-request label Jul 23, 2017

georgehrke mentioned this pull request Jul 23, 2017

[stable12] dont send invitations for past events #5841

Merged

georgehrke mentioned this pull request Aug 24, 2017

Do not send invites on import nextcloud/calendar#576

Closed

tcitworld approved these changes Aug 27, 2017

View reviewed changes

MorrisJobke requested changes Aug 30, 2017

View reviewed changes

georgehrke added 2 commits September 5, 2017 13:13

don't send invitation emails for past events

86f2866

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Sabre/VObject returns DateTimeImmutable, not a simple DateTime

a1df91d

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

georgehrke force-pushed the bugfix/2855/dont_send_invitations_for_past_events branch from 7e24c8c to a1df91d Compare September 5, 2017 11:13

MorrisJobke approved these changes Sep 5, 2017

View reviewed changes

MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed backport-request 3. to review Waiting for reviews labels Sep 5, 2017

MorrisJobke merged commit 8e6d86a into master Sep 6, 2017

MorrisJobke deleted the bugfix/2855/dont_send_invitations_for_past_events branch September 6, 2017 20:48

georgehrke mentioned this pull request Oct 11, 2017

Opt out of IMip CalDAV Plugin #6811

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't send invitation emails for past events #5304

don't send invitation emails for past events #5304

georgehrke commented Jun 8, 2017 •

edited

Loading

codecov bot commented Jun 9, 2017 •

edited

Loading

LukasReschke Jun 12, 2017

georgehrke Jun 12, 2017

georgehrke Jun 12, 2017

georgehrke Jun 12, 2017

ggeorgg Aug 24, 2017

georgehrke Aug 24, 2017 •

edited

Loading

MorrisJobke Aug 30, 2017

georgehrke Sep 5, 2017

kosli commented Jun 27, 2017

georgehrke commented Jun 28, 2017

kosli commented Jun 29, 2017

georgehrke commented Jul 17, 2017

georgehrke commented Jul 17, 2017

jospoortvliet commented Jul 18, 2017 •

edited

Loading

georgehrke commented Jul 23, 2017

ggeorgg commented Aug 22, 2017

jospoortvliet commented Aug 24, 2017

MorrisJobke Aug 30, 2017

jospoortvliet commented Sep 7, 2017

don't send invitation emails for past events #5304

don't send invitation emails for past events #5304

Conversation

georgehrke commented Jun 8, 2017 • edited Loading

codecov bot commented Jun 9, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

georgehrke Aug 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kosli commented Jun 27, 2017

georgehrke commented Jun 28, 2017

kosli commented Jun 29, 2017

georgehrke commented Jul 17, 2017

georgehrke commented Jul 17, 2017

jospoortvliet commented Jul 18, 2017 • edited Loading

georgehrke commented Jul 23, 2017

ggeorgg commented Aug 22, 2017

jospoortvliet commented Aug 24, 2017

Choose a reason for hiding this comment

jospoortvliet commented Sep 7, 2017

georgehrke commented Jun 8, 2017 •

edited

Loading

codecov bot commented Jun 9, 2017 •

edited

Loading

georgehrke Aug 24, 2017 •

edited

Loading

jospoortvliet commented Jul 18, 2017 •

edited

Loading