feat(internal-link): event on request

[ArtificialOwl]

Allow a modification of the behavior on internal-link request ('/index.php/f/12345')

Any listener can change the value of the FileId or even force a new Response() to be sent back to the client.

[provokateurin]

Not really happy about this hack 🤷‍♀️

[ArtificialOwl]

Not really happy about this hack 🤷‍♀️

went to something simpler: no changes are made to the file id, just the possibility to create a new Response

[come-nc]

Please explain the usecase better.
In nextcloud/globalsiteselector#177 you seem to expect fileId to be a composed field with two parts split by a dot.
But here you simply but the file id in the event, so it should be an int?

[ArtificialOwl]

I think I see the confusion with expecting fileid to be an int, but fileid was already considered string in that part of code, hence the cast.

Maybe rename the parameter ?

Regarding use-cases, the approach is to keep the same endpoint but store more data in the 'fileid' parameter.
an app intercept the event and generate its own Response instead of the default one which is a redirect to the file viewer.

The instant use of this feature is to store the identity of the local instance when creating internal link in a global scale env.
The end result is to have an internal link generated on instance A to redirect to a local file when used on instance B.

[come-nc]

I think I see the confusion with expecting fileid to be an int, but fileid was already considered string in that part of code, hence the cast.

But even your example in the description uses an int: "Allow a modification of the behavior on internal-link request ('/index.php/f/12345')"

Maybe rename the parameter ?

Regarding use-cases, the approach is to keep the same endpoint but store more data in the 'fileid' parameter. an app intercept the event and generate its own Response instead of the default one which is a redirect to the file viewer.

Why do you want to reuse the same endpoint for something else? You can use your own endpoint with your own parameters.

The instant use of this feature is to store the identity of the local instance when creating internal link in a global scale env. The end result is to have an internal link generated on instance A to redirect to a local file when used on instance B.

I did not understand yet who is generating the link. The global scale PR says "On the front-end, the generated link now contains the local identity token:
https://nc1.example.net/f/<token>.<fileid>", but does not contain any modification to frontend files.

[susnux]

Frontend wise its also easy to just use a new endpoint for GS instead, so we can have a clean API if that is what you requested.

E.g. we could also generate links for /gs/12314 instead of /f/1234 if global scale is used.

[ArtificialOwl]

closing, will allow globalsiteselector to manage root path

[ArtificialOwl]

closing, will allow globalsiteselector to manage root path