feat(core): Hide header in PWA #54138
Conversation
provokateurin
requested review from
artonge,
skjnldsv and
sorbaugh
and removed request for
a team
provokateurin
force-pushed
the
feat/core/pwa-hide-header
branch
from
cf6d548 to
09fcfc3
Compare
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I just tested this and it looks like this leads to a huge gap at the bottom. So I guess some additional css needs to be changed in this block. See
|
Good catch, I saw this as well, but somehow dismissed it as "normal". |
|
This is how the PR looks for me in a normal browser tab, so I actually think that the bug is caused by this PR |
provokateurin
force-pushed
the
feat/core/pwa-hide-header
branch
from
09fcfc3 to
434c5ce
Compare
|
Enough CSS adventures for me today :D |
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Tested again and seems to work as intended now :)
But did not review the code
|
/compile rebase |
Ah lol, it does not solve conflicts in css folders :p |
Signed-off-by: provokateurin <kate@provokateurin.de>
skjnldsv
force-pushed
the
feat/core/pwa-hide-header
branch
from
434c5ce to
4c7e85e
Compare
|
FYI @pulsejet |
|
@provokateurin somehow this breaks Talk after the update to nc32 rc1 on c.nc.c: |
|
Talk adds custom styles conflicting with server styles. cc @Antreesy
|
| } | ||
|
|
||
| #content, #content-vue { | ||
| margin-top: var(--body-container-margin); |
There was a problem hiding this comment.
Styles collide, but they're not from Talk, it's all server styles imported at different order
| Files | Talk |
|---|---|
 |
 |
As you're using id and not class, it's by default less important, and should be forced
| margin-top: var(--body-container-margin); | |
| margin-top: var(--body-container-margin) !important; |
|
User account details are not accessible in the per app PWA, when forcing the PWA to be the root of Nextcloud instance all apps loaded properly and full admin and user access in the PWA worked. |
|
This was reverted with #55397 |
Summary
We have one PWA per app, so the navigation bar doesn't make sense and takes up unnecessary space. The users can still use the navigation bar in the browser and open the settings and other non-app pages like that.
Checklist