perf(caldav): also cache empty share arrays #54438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
3. to review
st3iny
requested review from
a team,
CarlSchwan,
SebastianKrupinski and
icewind1991
SebastianKrupinski
approved these changes
Aug 16, 2025
AndyScherzinger
force-pushed
the
perf/caldav/cache-empty-shares-when-preloading
branch
from
9917859 to
4bce6be
Compare
Merged
CarlSchwan
approved these changes
Aug 28, 2025
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
perf/caldav/cache-empty-shares-when-preloading
branch
from
4bce6be to
0a79bc4
Compare
st3iny
added
4. to release
Member
Author
|
Oops, wanted to enable auto merge but accidentally closed the PR ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No shares (an empty array) is also a result that is worth to cache. I adjusted the logic accordingly to get rid of some superfluous (empty) queries on each calendar home PROPFIND.
Checklist