From fc8d188c9f63a45f0d7519ca7c7620f9cb4861de Mon Sep 17 00:00:00 2001 From: Maxence Lange Date: Thu, 21 Aug 2025 10:21:24 -0100 Subject: [PATCH] feat(lexicon): remove limitation to store definition only on cli Signed-off-by: Maxence Lange --- lib/public/Config/Lexicon/Entry.php | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/public/Config/Lexicon/Entry.php b/lib/public/Config/Lexicon/Entry.php index c810522dde5bb..aa35730c4f1c2 100644 --- a/lib/public/Config/Lexicon/Entry.php +++ b/lib/public/Config/Lexicon/Entry.php @@ -22,8 +22,6 @@ class Entry { /** @since 32.0.0 */ public const RENAME_INVERT_BOOLEAN = 1; - private string $definition = ''; - private string $note = ''; private ?string $default = null; /** @@ -46,24 +44,18 @@ public function __construct( private readonly string $key, private readonly ValueType $type, private null|string|int|float|bool|array|Closure $defaultRaw = null, - string $definition = '', + private readonly string $definition = '', private readonly bool $lazy = false, private readonly int $flags = 0, private readonly bool $deprecated = false, private readonly ?string $rename = null, private readonly int $options = 0, - string $note = '', + private readonly string $note = '', ) { // key can only contain alphanumeric chars and underscore "_" if (preg_match('/[^[:alnum:]_]/', $key)) { throw new \Exception('invalid config key'); } - - /** @psalm-suppress UndefinedClass */ - if (\OC::$CLI) { // only store definition if ran from CLI - $this->definition = $definition; - $this->note = $note; - } } /**