Skip to content

feat(lexicon): remove limitation to store definition only on cli #54559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

feat(lexicon): remove limitation to store definition only on cli #54559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions lib/public/Config/Lexicon/Entry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ class Entry {
/** @since 32.0.0 */
public const RENAME_INVERT_BOOLEAN = 1;

private string $definition = '';
private string $note = '';
private ?string $default = null;

/**
Expand All @@ -46,24 +44,18 @@ public function __construct(
private readonly string $key,
private readonly ValueType $type,
private null|string|int|float|bool|array|Closure $defaultRaw = null,
string $definition = '',
private readonly string $definition = '',
private readonly bool $lazy = false,
private readonly int $flags = 0,
private readonly bool $deprecated = false,
private readonly ?string $rename = null,
private readonly int $options = 0,
string $note = '',
private readonly string $note = '',
) {
// key can only contain alphanumeric chars and underscore "_"
if (preg_match('/[^[:alnum:]_]/', $key)) {
throw new \Exception('invalid config key');
}

/** @psalm-suppress UndefinedClass */
if (\OC::$CLI) { // only store definition if ran from CLI
$this->definition = $definition;
$this->note = $note;
}
}

/**
Expand Down
Loading