fix: iMip reply from outlook.com does not contain organizer property #54819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
st3iny and
tcitworld
as code owners
SebastianKrupinski
requested review from
kesselb
and removed request for
st3iny and
tcitworld
Contributor
Author
|
This is the issue we talked about at Team week. Missing organizer property in MS replies. This is the best solution I could think of, let me know if you think there is a better way? |
Contributor
Author
|
Tests missing, will write them when once the final solution is agreed on |
SebastianKrupinski
force-pushed
the
fix/issue-53949-imip-quirks-mode
branch
2 times, most recently
from
8ba04e5 to
b57dca7
Compare
SebastianKrupinski
requested review from
CarlSchwan,
salmart-dev and
yemkareems
and removed request for
a team
Contributor
Author
|
@kesselb The changes we talked about |
Contributor
Author
|
/backport to stable32 |
kesselb
approved these changes
Oct 7, 2025
lib/private/Calendar/Manager.php
Outdated
| $this->logger->warning('iMip message event dose not contains an organizer'); | ||
| return false; | ||
| // quirks mode: for Microsoft Exchange Servers use recipient as organizer if no organizer is set | ||
| if (isset($options['recipient']) && !empty($options['recipient'])) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (isset($options['recipient']) && !empty($options['recipient'])) { | |
| if (isset($options['recipient']) && $options['recipient'] !== '') { |
lib/public/Calendar/IManager.php
Outdated
| * Handles a iMip message | ||
| * | ||
| * @param array{absent?: "create"} $options | ||
| * @param array{absent?: "create"|"ignore", recipient?: string} $options |
Collaborator
There was a problem hiding this comment.
"ignore" has currently no effect?
Contributor
Author
There was a problem hiding this comment.
That was my ocd saying we have a create, there should be an ignore also
ChristophWurst
approved these changes
Oct 14, 2025
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/issue-53949-imip-quirks-mode
branch
from
488af41 to
ea2180d
Compare
Collaborator
|
/backport to stable31 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist