Skip to content

fix(theming): Remove header-icon-mask in dark-mode high-contrast as well #54832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

fix(theming): Remove header-icon-mask in dark-mode high-contrast as well #54832

merged 1 commit into from
Sep 3, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 3, 2025 •
edited
Loading

Before After
Bildschirmfoto vom 2025-09-03 12-56-07 Bildschirmfoto vom 2025-09-03 13-00-23

Checklist

@nickvergessen
fix(theming): Remove header icon mask in dark mode high contrast as well
edbb4e8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen requested a review from a team as a code owner September 3, 2025 10:59
@nickvergessen nickvergessen requested review from ArtificialOwl, nfebe and provokateurin and removed request for a team September 3, 2025 10:59
@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Sep 3, 2025
@nickvergessen nickvergessen changed the title fix(theming): Remove header icon mask in dark mode high contrast as well fix(theming): Remove header-icon-mask in dark-mode high-contrast as well Sep 3, 2025
@nickvergessen nickvergessen added this to the Nextcloud 32 milestone Sep 3, 2025
@provokateurin provokateurin merged commit 2c0f312 into master Sep 3, 2025
201 of 203 checks passed
@provokateurin provokateurin deleted the bugfix/noid/dark-contrast-appicon branch September 3, 2025 11:21
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 4, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@blizzz blizzz mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @AndyScherzinger @susnux @provokateurin @skjnldsv