fix: Stop infinite loop in ExpireTrash

[SystemKeeper]

Summary

• Regression from feat(files_trashbin): Refactor expire background job to support parallel run #52825

After updating to NC32, I noticed that cronjobs would not end anymore. Checking the DB revealed:

+----+----------------------------------------------+----------+------------+--------------+-------------+--------------------+------------------------------------------------------------------+----------------+
| id | class                                        | argument | last_run   | last_checked | reserved_at | execution_duration | argument_hash                                                    | time_sensitive |
+----+----------------------------------------------+----------+------------+--------------+-------------+--------------------+------------------------------------------------------------------+----------------+
|  5 | OCA\Files_Trashbin\BackgroundJob\ExpireTrash | null     | 1758741001 |   1758741001 |  1758741001 |               1800 | 74234e98afe7498fb5daf1f36ac2d78acc339464f950703b8c019892f982b90b |              1 |
+----+----------------------------------------------+----------+------------+--------------+-------------+--------------------+------------------------------------------------------------------+----------------+

There seems to be no exit condition, so we loop over all users for 30 minutes. From the mysql log:

# grep background_job_expire_trash_offset /tmp/mysql.log 
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '20', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '30', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '40', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '50', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '0', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '10', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '20', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '30', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '40', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '50', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '0', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '10', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '20', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')
		531567 Query	UPDATE `oc_appconfig` SET `configvalue` = '30', `lazy` = 0, `type` = 8 WHERE (`appid` = 'files_trashbin') AND (`configkey` = 'background_job_expire_trash_offset')

The original PR is about parallel runs, we might need a different check in that case, not totally sure.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[miaulalala]

Makes sense

[solracsf]

/backport to stable32

[backportbot]

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55290/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 58440bfc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55290/stable32

Error: Failed to push branch backport/55290/stable32: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[AndyScherzinger]

/backport to stable32

[solracsf]

Since the original PR was backported to 31 and 30, should this be backported too (to 31 at least) ?

[SystemKeeper]

/backport to stable31

[SystemKeeper]

/backport to stable30

[SystemKeeper]

/backport to stable31