Skip to content

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Oct 11, 2025

Summary

These entries are currently hard-coded in the manual itself (on the config parameter page that is generated from this config sample file) here.

This PR simple moves them to the proper place, the config sample file itself. They'll then still appear in that page in the manual.

A separate PR (nextcloud/documentation#13789) in the docs repo will remove their hard-coded entries in the manual, but this is not dependent on that PR.

Some light edits were made to the content (drawn from the separate Activity app chapter in the manual), but the focus of this PR isn't about improving the content itself so not overly concerned with making that perfect at this time (unless you see any obvious typo).

TODO

  • ...

Checklist

These entries are currently hard-coded in the manual itself (on the config parameter page that is generated from this config sample file). This PR moves them to the proper place, the config sample file itself.

A separate PR in the docs repo will remove their hard-coded entry in the manual, but this is not dependent on that PR.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards requested a review from a team as a code owner October 11, 2025 13:36
@joshtrichards joshtrichards added bug 3. to review Waiting for reviews labels Oct 11, 2025
@joshtrichards joshtrichards requested review from nfebe and removed request for a team October 11, 2025 13:36
@joshtrichards joshtrichards added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Oct 11, 2025
@joshtrichards joshtrichards requested a review from come-nc October 11, 2025 13:36
joshtrichards added a commit to nextcloud/documentation that referenced this pull request Oct 11, 2025
These options are moving to the config sample itself in the Server repo. See nextcloud/server#55706.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 33 milestone Oct 11, 2025
Corrected formatting and removed extra spaces in comments.

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@provokateurin provokateurin merged commit 4c2e71e into master Oct 13, 2025
189 of 191 checks passed
@provokateurin provokateurin deleted the jtr/fix-config-sample-activity-app branch October 13, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants