From 3900c45ea4441120dc3d67b537d005cddc90cfa2 Mon Sep 17 00:00:00 2001
From: Carl Schwan <carlschwan@kde.org>
Date: Thu, 22 Jan 2026 17:08:57 +0100
Subject: [PATCH] fix(Propagator): rollback transaction if it fails

---
 lib/private/Files/Cache/Propagator.php | 55 ++++++++++++++------------
 1 file changed, 30 insertions(+), 25 deletions(-)

diff --git a/lib/private/Files/Cache/Propagator.php b/lib/private/Files/Cache/Propagator.php
index 557d055c67b9f..4a0c320340123 100644
--- a/lib/private/Files/Cache/Propagator.php
+++ b/lib/private/Files/Cache/Propagator.php
@@ -160,40 +160,45 @@ public function commitBatch(): void {
 		}
 		$this->inBatch = false;
 
-		$this->connection->beginTransaction();
+		try {
+			$this->connection->beginTransaction();
 
-		$query = $this->connection->getQueryBuilder();
-		$storageId = $this->storage->getCache()->getNumericStorageId();
+			$query = $this->connection->getQueryBuilder();
+			$storageId = $this->storage->getCache()->getNumericStorageId();
 
-		$query->update('filecache')
-			->set('mtime', $query->func()->greatest('mtime', $query->createParameter('time')))
-			->set('etag', $query->expr()->literal(uniqid()))
-			->where($query->expr()->eq('storage', $query->createNamedParameter($storageId, IQueryBuilder::PARAM_INT)))
-			->andWhere($query->expr()->eq('path_hash', $query->createParameter('hash')));
+			$query->update('filecache')
+				->set('mtime', $query->func()->greatest('mtime', $query->createParameter('time')))
+				->set('etag', $query->expr()->literal(uniqid()))
+				->where($query->expr()->eq('storage', $query->createNamedParameter($storageId, IQueryBuilder::PARAM_INT)))
+				->andWhere($query->expr()->eq('path_hash', $query->createParameter('hash')));
 
-		$sizeQuery = $this->connection->getQueryBuilder();
-		$sizeQuery->update('filecache')
-			->set('size', $sizeQuery->func()->add('size', $sizeQuery->createParameter('size')))
-			->where($query->expr()->eq('storage', $sizeQuery->createNamedParameter($storageId, IQueryBuilder::PARAM_INT)))
-			->andWhere($query->expr()->eq('path_hash', $sizeQuery->createParameter('hash')))
-			->andWhere($sizeQuery->expr()->gt('size', $sizeQuery->createNamedParameter(-1, IQueryBuilder::PARAM_INT)));
+			$sizeQuery = $this->connection->getQueryBuilder();
+			$sizeQuery->update('filecache')
+				->set('size', $sizeQuery->func()->add('size', $sizeQuery->createParameter('size')))
+				->where($query->expr()->eq('storage', $sizeQuery->createNamedParameter($storageId, IQueryBuilder::PARAM_INT)))
+				->andWhere($query->expr()->eq('path_hash', $sizeQuery->createParameter('hash')))
+				->andWhere($sizeQuery->expr()->gt('size', $sizeQuery->createNamedParameter(-1, IQueryBuilder::PARAM_INT)));
 
-		foreach ($this->batch as $item) {
-			$query->setParameter('time', $item['time'], IQueryBuilder::PARAM_INT);
-			$query->setParameter('hash', $item['hash']);
+			foreach ($this->batch as $item) {
+				$query->setParameter('time', $item['time'], IQueryBuilder::PARAM_INT);
+				$query->setParameter('hash', $item['hash']);
 
-			$query->executeStatement();
+				$query->executeStatement();
 
-			if ($item['size']) {
-				$sizeQuery->setParameter('size', $item['size'], IQueryBuilder::PARAM_INT);
-				$sizeQuery->setParameter('hash', $item['hash']);
+				if ($item['size']) {
+					$sizeQuery->setParameter('size', $item['size'], IQueryBuilder::PARAM_INT);
+					$sizeQuery->setParameter('hash', $item['hash']);
 
-				$sizeQuery->executeStatement();
+					$sizeQuery->executeStatement();
+				}
 			}
-		}
 
-		$this->batch = [];
+			$this->batch = [];
 
-		$this->connection->commit();
+			$this->connection->commit();
+		} catch (\Exception $e) {
+			$this->connection->rollback();
+			throw $e;
+		}
 	}
 }