Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce length of md5 in scss caching #7504

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Conversation

skjnldsv
Copy link
Member

Easier to debug.

Before After
kazam_screenshot_00011 kazam_screenshot_00010

@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: scss labels Dec 14, 2017
@skjnldsv skjnldsv added this to the Nextcloud 13 milestone Dec 14, 2017
@skjnldsv skjnldsv self-assigned this Dec 14, 2017
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@MorrisJobke
Copy link
Member

Unit test failures.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the shorter-css-prefixes branch from 9b43461 to f2d5927 Compare December 14, 2017 10:12
@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #7504 into master will decrease coverage by 16.39%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #7504      +/-   ##
============================================
- Coverage     51.16%   34.77%   -16.4%     
  Complexity    24865    24865              
============================================
  Files          1601     1601              
  Lines         94683    94683              
  Branches       1368     1368              
============================================
- Hits          48446    32923   -15523     
- Misses        46237    61760   +15523
Impacted Files Coverage Δ Complexity Δ
lib/private/Template/SCSSCacher.php 6.34% <0%> (-63.5%) 36 <0> (ø)
lib/private/Files/ObjectStore/Mapper.php 0% <0%> (-100%) 2% <0%> (ø)
lib/private/App/AppStore/Bundles/Bundle.php 0% <0%> (-100%) 2% <0%> (ø)
...ddleware/Security/Exceptions/NotAdminException.php 0% <0%> (-100%) 1% <0%> (ø)
...Check/Iterator/ExcludeFileByNameFilterIterator.php 0% <0%> (-100%) 2% <0%> (ø)
apps/files_trashbin/appinfo/app.php 0% <0%> (-100%) 0% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Filter/Calendar.php 0% <0%> (-100%) 7% <0%> (ø)
lib/private/App/CodeChecker/EmptyCheck.php 0% <0%> (-100%) 6% <0%> (ø)
lib/public/AppFramework/Http/DownloadResponse.php 0% <0%> (-100%) 1% <0%> (ø)
apps/user_ldap/lib/Settings/Section.php 0% <0%> (-100%) 5% <0%> (ø)
... and 515 more

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

Test failure is unrelated, merging.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 14, 2017
@MorrisJobke MorrisJobke merged commit b19b137 into master Dec 14, 2017
@MorrisJobke MorrisJobke deleted the shorter-css-prefixes branch December 14, 2017 11:12
@MorrisJobke MorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: scss
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants