Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use deprecated method for requesting memcache #7531

Merged
merged 3 commits into from
Dec 18, 2017

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Dec 15, 2017

Quick and painless, create() already calls createDistributed(), effectively no change.

@codecov
Copy link

codecov bot commented Dec 15, 2017

Codecov Report

Merging #7531 into master will increase coverage by <.01%.
The diff coverage is 72.22%.

@@             Coverage Diff              @@
##             master    #7531      +/-   ##
============================================
+ Coverage     51.17%   51.18%   +<.01%     
  Complexity    24874    24874              
============================================
  Files          1601     1601              
  Lines         94707    94707              
  Branches       1368     1368              
============================================
+ Hits          48469    48473       +4     
+ Misses        46238    46234       -4
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/External/Storage.php 15.06% <0%> (ø) 58 <0> (ø) ⬇️
lib/private/Files/ObjectStore/Swift.php 0% <0%> (ø) 39 <0> (ø) ⬇️
lib/private/TemplateLayout.php 0% <0%> (ø) 45 <0> (ø) ⬇️
settings/ajax/uninstallapp.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/Command/Maintenance/UpdateTheme.php 73.33% <100%> (ø) 3 <0> (ø) ⬇️
lib/private/App/AppManager.php 95.58% <100%> (ø) 47 <0> (ø) ⬇️
lib/private/IntegrityCheck/Checker.php 81.85% <100%> (ø) 58 <0> (ø) ⬇️
apps/theming/lib/ThemingDefaults.php 92.08% <100%> (ø) 48 <0> (ø) ⬇️
apps/user_ldap/lib/Connection.php 57.87% <100%> (ø) 119 <0> (ø) ⬇️
lib/private/Server.php 81.01% <100%> (ø) 134 <0> (ø) ⬇️
... and 8 more

@MorrisJobke
Copy link
Member

Let's also fix the other occurrences

blizzz and others added 3 commits December 18, 2017 20:57
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the ldap/createdistributed branch from e2e104c to 094d419 Compare December 18, 2017 20:07
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed the test.
BUt other than that 👍

@rullzer rullzer merged commit a84d11d into master Dec 18, 2017
@rullzer rullzer deleted the ldap/createdistributed branch December 18, 2017 21:08
@MorrisJobke MorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants