Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let DI handle the background job #7561

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Let DI handle the background job #7561

merged 1 commit into from
Dec 18, 2017

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Dec 18, 2017

Fixes #7548

The DI can now do the magic itself. It could not before so we tricked it in Server.php. However then we failed to update the call to the constructor.

Long story short. Let the DI do the magic.

@rullzer
Let DI handle the background job
0b71369 
Fixes #7548

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added 3. to review Waiting for reviews bug labels Dec 18, 2017
@rullzer rullzer added this to the Nextcloud 13 milestone Dec 18, 2017
ChristophWurst
ChristophWurst approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DI all the things ✨ 🦄 🚀

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 18, 2017
@codecov
Copy link

codecov bot commented Dec 18, 2017 •
edited
Loading

Codecov Report

Merging #7561 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7561      +/-   ##
============================================
+ Coverage     51.17%   51.18%   +<.01%     
  Complexity    24874    24874              
============================================
  Files          1601     1601              
  Lines         94707    94701       -6     
  Branches       1368     1368              
============================================
+ Hits          48469    48474       +5     
+ Misses        46238    46227      -11
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 81.34% <ø> (+0.32%) 134 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
core/js/js.js 63.55% <0%> (+0.56%) 0% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

@rullzer rullzer merged commit 4ed12ff into master Dec 18, 2017
@rullzer rullzer deleted the fix_7548 branch December 18, 2017 20:12
@MorrisJobke
Copy link
Member

We should do this more often and the DI bootstrap container should be basically empty ;)

@MorrisJobke MorrisJobke mentioned this pull request Jan 2, 2018
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @MorrisJobke @ChristophWurst @blizzz