Fix file list visible behind the multiselect header #7663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parts of the file list contents (file name and actions) had a higher z-index than the file list multiselect header. That header is fixed in place, so when the file list contents were scrolled and those parts with a higher z-index overlapped the multiselect header they were fully visible. Now the z-index for the multiselect header has a higher value (the same used in the controls bar) to ensure that the contents are shown behind the header. Fixes #7540 Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
rullzer
deleted the
fix-file-list-visible-behind-the-multiselect-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7540
When the file list is scrolled vertically its contents are visible behind the file list multiselect header. As mentioned by @jancborchardt they are intended to be slightly visible, but currently some parts (the name and the file actions) are fully visible.
The problem comes from the z-index used for the header and those parts of the row; the z-index for
.nametextwas set to 50 in 22da869 and the z-index for.fileactionswas set to 50 in 5e02ced Both values are needed for the right behaviour of the file list, so this has to be fixed by setting an even higher z-index value for the header.When the original issue was filled the problem happened too in the controls bar (breadcrumbs and add button), but it was fixed in 3105a27 For consistency with that the z-index value of the header was set too to 55.
@nextcloud/designers