-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning if slash is entered as filename #7676
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
For now, fine 😉 But what do you think about creating a directory with that file when somebody types in "testfolder/testdoc.docx" as document name 🤔 @MorrisJobke |
Something for later and also a bit over the top from my point of view. |
* hides log entries for the case the parent folder does not exist Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Codecov Report
@@ Coverage Diff @@
## master #7676 +/- ##
===========================================
+ Coverage 51.19% 51.2% +0.01%
- Complexity 24888 24893 +5
===========================================
Files 1601 1602 +1
Lines 94781 94803 +22
Branches 1371 1372 +1
===========================================
+ Hits 48523 48544 +21
- Misses 46258 46259 +1
|
The second commit fixes all the cases of #6594 (comment) and logs them as debug logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange it was not already implemented! 🤔
Fixes #6594 when creating or renaming a file.