From e7c3b8da771c94f75acdac233b0da690459c4bab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Mon, 26 Mar 2018 12:28:25 +0200 Subject: [PATCH 1/2] Clear any theming prefixed cache on cache buster increase MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- apps/theming/lib/ThemingDefaults.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/theming/lib/ThemingDefaults.php b/apps/theming/lib/ThemingDefaults.php index 688878bb50a31..ce4ab0abb5540 100644 --- a/apps/theming/lib/ThemingDefaults.php +++ b/apps/theming/lib/ThemingDefaults.php @@ -320,7 +320,7 @@ public function shouldReplaceIcons() { private function increaseCacheBuster() { $cacheBusterKey = $this->config->getAppValue('theming', 'cachebuster', '0'); $this->config->setAppValue('theming', 'cachebuster', (int)$cacheBusterKey+1); - $this->cacheFactory->createDistributed('theming-')->clear('getScssVariables'); + $this->cacheFactory->createDistributed('theming-')->clear(); } /** From af4acdc6d664310c988d0ac9244338d2fc07a62a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Mon, 26 Mar 2018 14:29:28 +0200 Subject: [PATCH 2/2] Fix tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- apps/theming/tests/ThemingDefaultsTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/theming/tests/ThemingDefaultsTest.php b/apps/theming/tests/ThemingDefaultsTest.php index 2e1ad44b7aa25..2485a471bf46e 100644 --- a/apps/theming/tests/ThemingDefaultsTest.php +++ b/apps/theming/tests/ThemingDefaultsTest.php @@ -276,7 +276,7 @@ public function testSet() { $this->cache ->expects($this->once()) ->method('clear') - ->with('getScssVariables'); + ->with(''); $this->template->set('MySetting', 'MyValue'); }