From caee215120434420ba3f9cafd5b21c19b306d20d Mon Sep 17 00:00:00 2001
From: Roeland Jago Douma <roeland@famdouma.nl>
Date: Fri, 6 Apr 2018 15:44:28 +0200
Subject: [PATCH 1/3] Always remember me

Fixes #8004

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
---
 core/Controller/LoginController.php |  4 +---
 core/templates/login.php            | 10 ----------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/core/Controller/LoginController.php b/core/Controller/LoginController.php
index d0a91320e1fd0..fae997b1c6b4e 100644
--- a/core/Controller/LoginController.php
+++ b/core/Controller/LoginController.php
@@ -184,8 +184,6 @@ public function showLoginForm($user, $redirect_url, $remember_login) {
 		}
 
 		$parameters['alt_login'] = OC_App::getAlternativeLogIns();
-		$parameters['rememberLoginState'] = !empty($remember_login) ? $remember_login : 0;
-		$parameters['hideRemeberLoginState'] = !empty($redirect_url) && $this->session->exists('client.flow.state.token');
 
 		if ($user !== null && $user !== '') {
 			$parameters['loginName'] = $user;
@@ -240,7 +238,7 @@ private function generateRedirect($redirectUrl) {
 	 * @param string $timezone_offset
 	 * @return RedirectResponse
 	 */
-	public function tryLogin($user, $password, $redirect_url, $remember_login = false, $timezone = '', $timezone_offset = '') {
+	public function tryLogin($user, $password, $redirect_url, $remember_login = true, $timezone = '', $timezone_offset = '') {
 		if(!is_string($user)) {
 			throw new \InvalidArgumentException('Username must be string');
 		}
diff --git a/core/templates/login.php b/core/templates/login.php
index 3633400b312de..ee1ce6a687006 100644
--- a/core/templates/login.php
+++ b/core/templates/login.php
@@ -76,16 +76,6 @@
 		<?php } ?>
 
 		<div class="login-additional">
-			<?php if (!$_['hideRemeberLoginState']) { ?>
-			<div class="remember-login-container">
-				<?php if ($_['rememberLoginState'] === 0) { ?>
-				<input type="checkbox" name="remember_login" value="1" id="remember_login" class="checkbox checkbox--white">
-				<?php } else { ?>
-				<input type="checkbox" name="remember_login" value="1" id="remember_login" class="checkbox checkbox--white" checked="checked">
-				<?php } ?>
-				<label for="remember_login"><?php p($l->t('Stay logged in')); ?></label>
-			</div>
-			<?php } ?>
 			<?php if (!empty($_['canResetPassword'])) { ?>
 			<div class="lost-password-container">
 				<a id="lost-password" href="<?php p($_['resetPasswordLink']); ?>">

From 2b7d4d506976d26d1820cea3601953ed6e189f24 Mon Sep 17 00:00:00 2001
From: Roeland Jago Douma <roeland@famdouma.nl>
Date: Fri, 6 Apr 2018 19:58:37 +0200
Subject: [PATCH 2/3] Fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
---
 core/Controller/LoginController.php           |  3 ++-
 tests/Core/Controller/LoginControllerTest.php | 22 +++++--------------
 2 files changed, 7 insertions(+), 18 deletions(-)

diff --git a/core/Controller/LoginController.php b/core/Controller/LoginController.php
index fae997b1c6b4e..41467c5c88761 100644
--- a/core/Controller/LoginController.php
+++ b/core/Controller/LoginController.php
@@ -33,6 +33,7 @@
 
 namespace OC\Core\Controller;
 
+use OC\Authentication\Token\IToken;
 use OC\Authentication\TwoFactorAuth\Manager;
 use OC\Security\Bruteforce\Throttler;
 use OC\User\Session;
@@ -286,7 +287,7 @@ public function tryLogin($user, $password, $redirect_url, $remember_login = true
 		// TODO: remove password checks from above and let the user session handle failures
 		// requires https://github.com/owncloud/core/pull/24616
 		$this->userSession->completeLogin($loginResult, ['loginName' => $user, 'password' => $password]);
-		$this->userSession->createSessionToken($this->request, $loginResult->getUID(), $user, $password, (int)$remember_login);
+		$this->userSession->createSessionToken($this->request, $loginResult->getUID(), $user, $password, IToken::REMEMBER);
 
 		// User has successfully logged in, now remove the password reset link, when it is available
 		$this->config->deleteUserValue($loginResult->getUID(), 'core', 'lostpassword');
diff --git a/tests/Core/Controller/LoginControllerTest.php b/tests/Core/Controller/LoginControllerTest.php
index c0de180abbad6..ccd70111ae5d1 100644
--- a/tests/Core/Controller/LoginControllerTest.php
+++ b/tests/Core/Controller/LoginControllerTest.php
@@ -21,6 +21,7 @@
 
 namespace Tests\Core\Controller;
 
+use OC\Authentication\Token\IToken;
 use OC\Authentication\TwoFactorAuth\Manager;
 use OC\Core\Controller\LoginController;
 use OC\Security\Bruteforce\Throttler;
@@ -193,9 +194,7 @@ public function testShowLoginFormWithErrorsInSession() {
 				'user_autofocus' => true,
 				'canResetPassword' => true,
 				'alt_login' => [],
-				'rememberLoginState' => 0,
 				'resetPasswordLink' => null,
-				'hideRemeberLoginState' => false,
 				'throttle_delay' => 1000,
 			],
 			'guest'
@@ -208,11 +207,6 @@ public function testShowLoginFormForFlowAuth() {
 			->expects($this->once())
 			->method('isLoggedIn')
 			->willReturn(false);
-		$this->session
-			->expects($this->once())
-			->method('exists')
-			->with('client.flow.state.token')
-			->willReturn(true);
 
 		$expectedResponse = new TemplateResponse(
 			'core',
@@ -224,9 +218,7 @@ public function testShowLoginFormForFlowAuth() {
 				'user_autofocus' => true,
 				'canResetPassword' => true,
 				'alt_login' => [],
-				'rememberLoginState' => 0,
 				'resetPasswordLink' => null,
-				'hideRemeberLoginState' => true,
 				'throttle_delay' => 1000,
 			],
 			'guest'
@@ -284,9 +276,7 @@ public function testShowLoginFormWithPasswordResetOption($canChangePassword,
 				'user_autofocus' => false,
 				'canResetPassword' => $expectedResult,
 				'alt_login' => [],
-				'rememberLoginState' => 0,
 				'resetPasswordLink' => false,
-				'hideRemeberLoginState' => false,
 				'throttle_delay' => 1000,
 			],
 			'guest'
@@ -324,9 +314,7 @@ public function testShowLoginFormForUserNamedNull() {
 				'user_autofocus' => false,
 				'canResetPassword' => false,
 				'alt_login' => [],
-				'rememberLoginState' => 0,
 				'resetPasswordLink' => false,
-				'hideRemeberLoginState' => false,
 				'throttle_delay' => 1000,
 			],
 			'guest'
@@ -395,7 +383,7 @@ public function testLoginWithValidCredentials() {
 			->with($user, ['loginName' => $loginName, 'password' => $password]);
 		$this->userSession->expects($this->once())
 			->method('createSessionToken')
-			->with($this->request, $user->getUID(), $loginName, $password, false);
+			->with($this->request, $user->getUID(), $loginName, $password, IToken::REMEMBER);
 		$this->twoFactorManager->expects($this->once())
 			->method('isTwoFactorAuthenticated')
 			->with($user)
@@ -535,7 +523,7 @@ public function testLoginWithValidCredentialsAndRedirectUrl() {
 			->will($this->returnValue($user));
 		$this->userSession->expects($this->once())
 			->method('createSessionToken')
-			->with($this->request, $user->getUID(), 'Jane', $password, false);
+			->with($this->request, $user->getUID(), 'Jane', $password, IToken::REMEMBER);
 		$this->userSession->expects($this->once())
 			->method('isLoggedIn')
 			->with()
@@ -574,7 +562,7 @@ public function testLoginWithOneTwoFactorProvider() {
 			->with($user, ['loginName' => 'john@doe.com', 'password' => $password]);
 		$this->userSession->expects($this->once())
 			->method('createSessionToken')
-			->with($this->request, $user->getUID(), 'john@doe.com', $password, false);
+			->with($this->request, $user->getUID(), 'john@doe.com', $password, IToken::REMEMBER);
 		$this->twoFactorManager->expects($this->once())
 			->method('isTwoFactorAuthenticated')
 			->with($user)
@@ -628,7 +616,7 @@ public function testLoginWithMultpleTwoFactorProviders() {
 			->with($user, ['loginName' => 'john@doe.com', 'password' => $password]);
 		$this->userSession->expects($this->once())
 			->method('createSessionToken')
-			->with($this->request, $user->getUID(), 'john@doe.com', $password, false);
+			->with($this->request, $user->getUID(), 'john@doe.com', $password, IToken::REMEMBER);
 		$this->twoFactorManager->expects($this->once())
 			->method('isTwoFactorAuthenticated')
 			->with($user)

From 33b93db953e66b77c71b67f74f8d7d1039b0056a Mon Sep 17 00:00:00 2001
From: Roeland Jago Douma <roeland@famdouma.nl>
Date: Fri, 6 Apr 2018 21:44:23 +0200
Subject: [PATCH 3/3] Remove unused parameter

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
---
 core/Controller/LoginController.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/core/Controller/LoginController.php b/core/Controller/LoginController.php
index 41467c5c88761..ffa5b10fc2ff7 100644
--- a/core/Controller/LoginController.php
+++ b/core/Controller/LoginController.php
@@ -138,11 +138,10 @@ public function logout() {
 	 *
 	 * @param string $user
 	 * @param string $redirect_url
-	 * @param string $remember_login
 	 *
 	 * @return TemplateResponse|RedirectResponse
 	 */
-	public function showLoginForm($user, $redirect_url, $remember_login) {
+	public function showLoginForm($user, $redirect_url) {
 		if ($this->userSession->isLoggedIn()) {
 			return new RedirectResponse(OC_Util::getDefaultPageUrl());
 		}