-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #9318: catch exceptions in SCSSCacher::resetCache() #9352
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9352 +/- ##
============================================
+ Coverage 51.2% 51.93% +0.72%
+ Complexity 25580 25395 -185
============================================
Files 1563 1608 +45
Lines 88054 95447 +7393
Branches 0 1393 +1393
============================================
+ Hits 45087 49566 +4479
- Misses 42967 45881 +2914
|
$file->delete(); | ||
try { | ||
$file->delete(); | ||
} catch(NotPermittedException $e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is not the NotPermittedException that gets thrown here... (I know the phpdoc says that is what it throws). But I guess it fails on some uncatched thing deep in the code.
Better catch a bit more generic here I think
@rullzer Have a look at the stack trace in #9318 : Actually it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then lets do this!
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
0d47624
to
6270a01
Compare
rebased to trigger ci again |
@Cybso Mind to open a backport PR? Just base a branch on |
@MorrisJobke I tried in #9376, but I think I accidentally merged all changes in master...?! Here's what I did:
|
@Cybso Just use the commit sha from this PR:
That then should work ;) |
Ok, I think I got it right, now :-) |
Fixes hard fails when SCSSCacher::resetCache() is not able to delete a cached file, as described in issue #9318 after an upgrade from Nextcloud 13.0.0.0 to 13.0.0.2.