-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Invalid argument supplied for foreach()" #9360
Fix "Invalid argument supplied for foreach()" #9360
Conversation
Signed-off-by: Roger Szabo <roger.szabo@web.de>
cc @nextcloud/ldap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 make sense.
In future, please use short notations [ … ]
for arrays.
@GitHubUser4234 tests are failing |
Signed-off-by: Roger Szabo <roger.szabo@web.de>
Codecov Report
@@ Coverage Diff @@
## master #9360 +/- ##
============================================
- Coverage 51.76% 51.61% -0.16%
- Complexity 25562 25684 +122
============================================
Files 1627 1638 +11
Lines 95952 96283 +331
Branches 1393 1393
============================================
+ Hits 49673 49697 +24
- Misses 46279 46586 +307
|
@blizzz yeah, unit tests had to be adjusted also ^^ |
Awesome stuff once agian @GitHubUser4234 thnx |
@GitHubUser4234 @blizzz @rullzer Maybe worth a backport, right? |
backport is in #9654 |
Fixes #7804