Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Invalid argument supplied for foreach()" #9360

Merged

Conversation

GitHubUser4234
Copy link
Contributor

Fixes #7804

Signed-off-by: Roger Szabo <roger.szabo@web.de>
@MorrisJobke
Copy link
Member

cc @nextcloud/ldap

@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone May 2, 2018
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 make sense.

In future, please use short notations [ … ] for arrays.

@blizzz
Copy link
Member

blizzz commented May 7, 2018

@GitHubUser4234 tests are failing

Signed-off-by: Roger Szabo <roger.szabo@web.de>
@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #9360 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #9360      +/-   ##
============================================
- Coverage     51.76%   51.61%   -0.16%     
- Complexity    25562    25684     +122     
============================================
  Files          1627     1638      +11     
  Lines         95952    96283     +331     
  Branches       1393     1393              
============================================
+ Hits          49673    49697      +24     
- Misses        46279    46586     +307
Impacted Files Coverage Δ Complexity Δ
apps/user_ldap/lib/User/User.php 75.25% <100%> (ø) 123 <0> (ø) ⬇️
apps/files_versions/lib/AppInfo/Application.php 68.75% <0%> (-31.25%) 3% <0%> (+1%)
apps/files_external/lib/Lib/Storage/OwnCloud.php 84% <0%> (-7.31%) 7% <0%> (+1%)
lib/private/Log.php 73.07% <0%> (-4.46%) 35% <0%> (-5%)
lib/private/Template/SCSSCacher.php 71.62% <0%> (-0.8%) 39% <0%> (+1%)
lib/private/Settings/Manager.php 64.33% <0%> (-0.67%) 42% <0%> (ø)
apps/dav/lib/Connector/Sabre/File.php 72.79% <0%> (-0.42%) 100% <0%> (-3%)
lib/private/Files/View.php 85.08% <0%> (-0.21%) 380% <0%> (ø)
apps/files_sharing/lib/External/Storage.php 14.88% <0%> (-0.18%) 59% <0%> (+1%)
lib/private/Server.php 82.56% <0%> (-0.02%) 280% <0%> (+2%)
... and 48 more

@GitHubUser4234
Copy link
Contributor Author

@blizzz yeah, unit tests had to be adjusted also ^^

@rullzer rullzer merged commit 58e4ddd into nextcloud:master May 10, 2018
@rullzer
Copy link
Member

rullzer commented May 10, 2018

Awesome stuff once agian @GitHubUser4234 thnx

@MorrisJobke
Copy link
Member

@GitHubUser4234 @blizzz @rullzer Maybe worth a backport, right?

@MorrisJobke
Copy link
Member

backport is in #9654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants