cleanup locks in scanner on error #9395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
approved these changes
May 7, 2018
| } finally { | ||
| if ($lock) { | ||
| if ($this->storage->instanceOfStorage('\OCP\Files\Storage\ILockingStorage')) { | ||
| $this->storage->releaseLock($path, ILockingProvider::LOCK_SHARED, $this->lockingProvider); |
There was a problem hiding this comment.
makes php EA go mimimi,
Unhandled exception in finally causes unexpected behaviour in various php versions,
whatever that means
There was a problem hiding this comment.
Seems to work on the versions we support: https://3v4l.org/cG66R
And it is better than nowadays - so go for this way.
MorrisJobke
approved these changes
May 23, 2018
rullzer
approved these changes
May 23, 2018
This was referenced May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while investigating other lock issues