Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable13] Dont use $info as array when its not an array #9525

Merged
merged 1 commit into from
May 22, 2018
Merged

[stable13] Dont use $info as array when its not an array #9525

merged 1 commit into from
May 22, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 18, 2018

backport of #8504

@nickvergessen @blizzz
Dont use $info as array when its not an array
ccedb31 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@blizzz blizzz added bug 3. to review Waiting for reviews labels May 18, 2018
@blizzz blizzz added this to the Nextcloud 13.0.3 milestone May 18, 2018
@blizzz blizzz requested review from rullzer and MorrisJobke May 18, 2018 21:52
@codecov
Copy link

codecov bot commented May 18, 2018 •
edited
Loading

Codecov Report

Merging #9525 into stable13 will increase coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable13    #9525      +/-   ##
==============================================
+ Coverage       51.38%   51.38%   +<.01%     
  Complexity      25052    25052              
==============================================
  Files            1609     1609              
  Lines           95350    95350              
  Branches         1376     1376              
==============================================
+ Hits            48999    49000       +1     
+ Misses          46351    46350       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Installer.php 58.17% <0%> (ø) 77 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️

MorrisJobke
MorrisJobke approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit bae5ec5 into stable13 May 22, 2018
@MorrisJobke MorrisJobke deleted the backport/8504/stable13 branch May 22, 2018 14:33
@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 13.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@blizzz @rullzer @MorrisJobke @nickvergessen