[stable13] Fix settings menu #9590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
MorrisJobke,
jancborchardt,
blizzz and
skjnldsv
|
Nice catch! Doesn't happen on master to me as well :/ |
skjnldsv
approved these changes
May 24, 2018
skjnldsv
added
4. to release
|
I don't get it, My current setup was a few commits late and I did not have this issue. |
|
@skjnldsv I also needed a hard refresh to reload the css to make it occur. 😉 |
|
Found the commits responsible: |
Closed
|
@juliushaertl woah, it was introduced in 2012? |
|
@jancborchardt no, julius linked the wrong commit. |
|
Oh sorry about that ... Somehow got the link wrong. 🙈 @skjnldsv posted the right link. |
|
Riight, that’s what I thought :D |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9514 which was introduced in fc280b2 where the settings menu was moved to a nav element and therefore the css rules scope was to wide.
Doesn't happen on master to me.
Before:
After:
@nextcloud/designers