[stable13] Emit event when running ./occ db:add-missing-indices #9620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
MorrisJobke,
ChristophWurst,
schiessle and
juliusknorr
| @@ -1,4 +1,5 @@ | |||
| <?php | |||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
Shouldn't stable13 be compatible with php5.6? Does this line work for that?
There was a problem hiding this comment.
yes you are right... Let me fix that
This allows apps to listen to this event in order to also update indecies there. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
backport/9576/stable13
branch
from
b2c610d to
dd5995a
Compare
Codecov Report
@@ Coverage Diff @@
## stable13 #9620 +/- ##
==============================================
- Coverage 50.87% 50.87% -0.01%
Complexity 25097 25097
==============================================
Files 1547 1547
Lines 87718 87723 +5
==============================================
Hits 44628 44628
- Misses 43090 43095 +5
|
juliusknorr
approved these changes
May 29, 2018
juliusknorr
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9576