Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Do not load calendar/addressbook plugins if not needed #9655

Merged
merged 8 commits into from
May 31, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented May 29, 2018

Backport of #9268

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elephant

rullzer added 6 commits May 30, 2018 13:27
Fixes #6711
Based on owncloud/core@f0fb21c

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
…ied to be valid

owncloud/core@d3fb8fc

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
…ollection as well

owncloud/core@9f2e643

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
owncloud/core@edacf22

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
People that have issues can run it manually

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@skjnldsv skjnldsv force-pushed the backport/9268/stable13 branch from 6b4f559 to 4fae9be Compare May 30, 2018 11:28
@skjnldsv
Copy link
Member

Rebased

@codecov
Copy link

codecov bot commented May 30, 2018

Codecov Report

Merging #9655 into stable13 will increase coverage by 0.01%.
The diff coverage is 76.38%.

@@              Coverage Diff               @@
##             stable13    #9655      +/-   ##
==============================================
+ Coverage       51.43%   51.44%   +0.01%     
- Complexity      25106    25120      +14     
==============================================
  Files            1612     1613       +1     
  Lines           95544    95589      +45     
  Branches         1376     1376              
==============================================
+ Hits            49143    49179      +36     
- Misses          46401    46410       +9
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Connector/Sabre/Principal.php 86.84% <0%> (-3.99%) 48 <0> (+2)
apps/dav/composer/composer/autoload_classmap.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/dav/composer/composer/autoload_static.php 0% <0%> (ø) 1 <0> (ø) ⬇️
apps/dav/composer/composer/ClassLoader.php 0% <0%> (ø) 64 <0> (-1) ⬇️
apps/dav/lib/CardDAV/AddressBook.php 57.5% <100%> (ø) 28 <0> (ø) ⬇️
apps/dav/lib/DAV/Sharing/Backend.php 87.36% <100%> (+0.55%) 26 <5> (+2) ⬆️
apps/dav/lib/CalDAV/Calendar.php 70.28% <100%> (ø) 48 <0> (ø) ⬇️
apps/dav/lib/Command/RemoveInvalidShares.php 92% <92%> (ø) 6 <6> (?)
apps/dav/lib/Server.php 47.46% <95.83%> (+2.8%) 22 <3> (+5) ⬆️
... and 1 more

@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

cough cough I removed the type hints for PHP 5.6 compatibility. 😉

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 31, 2018
@rullzer rullzer merged commit f7372be into stable13 May 31, 2018
@rullzer rullzer deleted the backport/9268/stable13 branch May 31, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants