[stable13] check user state when fetching to avoid dealing with offline objects #9662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
May 29, 2018
MorrisJobke
added
4. to release
MorrisJobke
reviewed
May 29, 2018
apps/user_ldap/lib/Access.php
Outdated
| @@ -52,7 +52,6 @@ | |||
|
|
|||
| use OC\ServerNotAvailableException; | |||
| use OCP\IConfig; | |||
| use OCP\Util; | |||
There was a problem hiding this comment.
This causes Phan to fail:
apps/user_ldap/lib/Access.php:588 PhanUndeclaredClassConstant Reference to constant WARN from undeclared class \OCA\User_LDAP\Util
apps/user_ldap/lib/Access.php:1978 PhanUndeclaredClassConstant Reference to constant DEBUG from undeclared class \OCA\User_LDAP\Util
fixes #9502 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
MorrisJobke
force-pushed
the
backport/9640/stable13
branch
from
8882d32 to
d33ba08
Compare
Codecov Report
@@ Coverage Diff @@
## stable13 #9662 +/- ##
==============================================
+ Coverage 51.39% 51.44% +0.04%
- Complexity 25104 25105 +1
==============================================
Files 1612 1612
Lines 95545 95562 +17
Branches 1376 1376
==============================================
+ Hits 49107 49158 +51
+ Misses 46438 46404 -34
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #9640