Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] Fix: Curl CURLOPT_BINARYTRANSFER deprecated #1879

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Ayesh
Copy link
Contributor

@Ayesh Ayesh commented Jan 16, 2024

The CURLOPT_BINARYTRANSFER PHP constant from the Curl extension was no-op since PHP 5.1, and is deprecated in PHP 8.4. This removes the constant usage to avoid the deprecation notice in PHP 8.4 and later.

Because this constant was no-op since PHP 5.1 (circa 2005), this change has no impact.

See:

  • Resolves: #
  • Target version: master

Summary

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@artonge
Copy link
Contributor

artonge commented Nov 25, 2024

@Ayesh can you fix the DCO?
And sorry for noticing your PR only now.

The `CURLOPT_BINARYTRANSFER` PHP constant from the Curl extension was no-op since
PHP 5.1, and is deprecated in PHP 8.4. This removes the constant usage to avoid
the deprecation notice in PHP 8.4 and later.

Because this constant was no-op since PHP 5.1 (circa 2005), this change has no
impact.

See:

 - [PHP.Watch - PHP 8.4 - Curl: CURLOPT_BINARYTRANSFER deprecated](https://php.watch/versions/8.4/CURLOPT_BINARYTRANSFER-deprecated)
 - [commit](php/php-src@fc16285)

Signed-off-by: Ayesh Karunaratne <ayesh@aye.sh>
@Ayesh
Copy link
Contributor Author

Ayesh commented Nov 25, 2024

Thank you @artonge. I signed the commit and force-pushed.

@come-nc come-nc merged commit 237005f into nextcloud:master Nov 26, 2024
38 of 40 checks passed
@come-nc
Copy link
Contributor

come-nc commented Nov 26, 2024

@Ayesh

Thank you for your contribution!
We have a Nextcloud Talk instance where we invite Nextcloud contributors to be able to communicate more quickly, and we also have channels (one of them for Social app). If you like, I could give you a guest account via the email address in your commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants